eolivelli commented on code in PR #2038:
URL: https://github.com/apache/zookeeper/pull/2038#discussion_r1311657615
##########
zookeeper-server/src/test/java/org/apache/zookeeper/test/ClientSSLTest.java:
##########
@@ -147,6 +148,8 @@ public void testClientServerSSLWithCnxnClassName() throws
Exception {
@ParameterizedTest(name = "sslProvider={0}, fipsEnabled={1},
hostnameVerification={2}")
@MethodSource("positiveTestData")
public void testClientServerSSL_positive(SslProvider sslProvider, String
fipsEnabled, String hostnameVerification) throws Exception {
+ //Skipping this test for s390x arch as netty-tc-native is not supported
+ assumeFalse(System.getProperty("os.arch").contains("s390x"), "
Skipping for s390x arch as netty-tcnative is not yet supported.");
Review Comment:
yes, it is required for each PRs, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
