eolivelli commented on code in PR #2005:
URL: https://github.com/apache/zookeeper/pull/2005#discussion_r1225273214
##########
zookeeper-server/src/main/java/org/apache/zookeeper/common/NetUtils.java:
##########
@@ -27,17 +27,18 @@
*/
public class NetUtils {
+ /**
+ * Prefer using the hostname for formatting, but without requesting
reverse DNS lookup.
+ * Fall back to IP address if hostname is unavailable and use [] brackets
for IPv6 literal.
+ */
public static String formatInetAddr(InetSocketAddress addr) {
+ String hostString = addr.getHostString();
InetAddress ia = addr.getAddress();
- if (ia == null) {
- return String.format("%s:%s", addr.getHostString(),
addr.getPort());
- }
-
- if (ia instanceof Inet6Address) {
- return String.format("[%s]:%s", ia.getHostAddress(),
addr.getPort());
+ if (ia instanceof Inet6Address && hostString.contains(":")) {
Review Comment:
Can hostString be null?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
