fanyang89 commented on PR #314:
URL: https://github.com/apache/zookeeper/pull/314#issuecomment-1537091718

   @lvfangmin 
   
   > we rely on the digest mismatch detected after DIFF sync and force a SNAP 
sync
   When syncing, I implemented a mechanism to calculate data tree checksum and 
send it in a NEWLEADER message. If checksum doesn't match, it falls back to 
SNAP sync. But I wouldn't say I like this approach because it may cover up the 
real sync issue.
   
   As a result, I would turn off on disk txn sync by setting 
`snapshotSizeFactor=-1` since not all quorum peer have all txn logs with a 
former version of ZooKeeper without digest supports (ZOOKEEPER-3150). If anyone 
wants, just upgrade to 3.6 or above.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to