laxmanprabhu commented on PR #1257: URL: https://github.com/apache/zookeeper/pull/1257#issuecomment-1512214435
The `cleanUp` method is also called by `cleanAndNotifyState()`. Is there a reason why `cleanUp` method call isn't synchronized in this code path as well. When `cleanAndNotifyState()` calls cleanUp, the outgoingQueue is iterated without any synchronization. During this stage more callers can queue requests to the outgoingQueue. This causes the cleanUp method to keep iterating and possible take long time to complete. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
