li4wang commented on code in PR #1966:
URL: https://github.com/apache/zookeeper/pull/1966#discussion_r1116290975


##########
zookeeper-server/src/main/java/org/apache/zookeeper/server/auth/AuthenticationProvider.java:
##########
@@ -49,6 +52,19 @@ public interface AuthenticationProvider {
      */
     KeeperException.Code handleAuthentication(ServerCnxn cnxn, byte[] 
authData);
 
+    /**
+     * This method is called when admin server command passes authentication 
data for this
+     * scheme.
+     *
+     * @param request
+     *                the request that contains the authentication information.
+     * @param authData
+     *                the authentication data received.
+     * @return Ids
+     *                the list of Id. Empty list means not authenticated
+     */
+    List<Id> handleAuthentication(HttpServletRequest request, byte[] authData);

Review Comment:
   Yep, good idea. Changed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to