[
https://issues.apache.org/jira/browse/THRIFT-6396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jens Geyer resolved THRIFT-6396.
--------------------------------
Fix Version/s: 0.26.0
Assignee: Jens Geyer
Resolution: Fixed
> Let a manual run of the WinGet and Chocolatey workflows publish
> ---------------------------------------------------------------
>
> Key: THRIFT-6396
> URL: https://issues.apache.org/jira/browse/THRIFT-6396
> Project: Thrift
> Issue Type: Bug
> Components: Build Process
> Reporter: Jens Geyer
> Assignee: Jens Geyer
> Priority: Major
> Fix For: 0.26.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> {{doc/ReleaseManagement.md}} says to run the WinGet workflow again from the
> Actions tab once {{archive.apache.org}} has the installer, and the header of
> the Chocolatey workflow says the same. Such a manual run cannot publish
> anything:
> * the steps that render the manifests and build the package only download the
> published installer when {{github.event_name == 'release'}}, so a manual run
> uses the placeholder checksum {{DEADBEEF...}};
> * the submit and push jobs only run for a release, so a manual run skips them.
> The manual run is green, and the placeholder manifests and package are left
> behind as artifacts.
> The 0.25.0 release ran into this. The release runs of both workflows failed,
> because the installer is not in {{dist/release/thrift/0.25.0}}, and the
> documented way to try again would not have published anything.
> h2. Change
> * Only a pull request uses the placeholder. A manual run downloads the
> published installer, and submits or pushes like a release run.
> * {{doc/ReleaseManagement.md}}:
> ** how to add the installer to {{dist/release}} after the release, when it
> was not part of the release candidate. It has to be built from the voted
> compiler: the {{windows-installer}} artifact of the {{Windows packages}}
> workflow contains a compiler that the workflow built itself;
> ** a release run can be re-run for 30 days, and a manual run needs the
> version and, for WinGet, the release date;
> ** the Chocolatey section still described the maintainer takeover of the
> {{thrift}} id as pending and said that nothing is pushed; both are out of
> date;
> ** the secrets and the variable can be set for the repository or for the
> {{release}} environment.
> _Drafted with AI assistance (Claude Opus 5.5)._
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
