Jens-G opened a new pull request, #3983: URL: https://github.com/apache/thrift/pull/3983
[THRIFT-6396](https://issues.apache.org/jira/browse/THRIFT-6396) When a WinGet or Chocolatey release run is too early for `archive.apache.org`, `doc/ReleaseManagement.md` says to run the workflow again from the Actions tab. Such a manual run could not publish anything: - only a `release` event downloaded the published installer, so a manual run rendered the manifests and packed the package with the `DEADBEEF…` placeholder checksum; - the submit and push jobs only ran for a `release` event, so a manual run skipped them and still finished green. Now only a pull request uses the placeholder. A manual run downloads the published installer and submits or pushes like a release run. Pull requests and pre-releases behave as before. `doc/ReleaseManagement.md`: - how to add the installer to `dist/release` after the release, when it was not part of the release candidate, as for 0.25.0. It has to be built from the voted compiler; the `windows-installer` artifact of `Windows packages` contains a compiler that the workflow built itself; - a release run can be re-run for 30 days, and a manual WinGet run needs the release date as well as the version; - the Chocolatey section no longer describes the takeover of the `thrift` id as pending; the workflow's comments and run summary are updated to match; - the secrets and the variable can be set for the repository or for the `release` environment. **Verification** A script evaluates the job conditions and the environment of the render/build step from the workflow file for each kind of event, then runs the step's PowerShell with `VERSION=0.25.0`: | Event | master | this PR | |---|---|---| | `pull_request` | placeholder; no submit/push | unchanged | | `workflow_dispatch` | placeholder; submit/push skipped | downloads `archive.apache.org/dist/thrift/0.25.0/thrift-0.25.0-setup.exe`; submit/push runs | | `release` | downloads the installer; submit/push runs | unchanged | | `release`, pre-release | submit/push skipped | unchanged | The download itself returns 404 today, because the 0.25.0 installer is not on the archive yet; for this check it only matters that it is attempted. actionlint and zizmor (`--persona regular`, with a token) report nothing. 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
