Jens-G opened a new pull request, #3964: URL: https://github.com/apache/thrift/pull/3964
[THRIFT-6390](https://issues.apache.org/jira/browse/THRIFT-6390), item 3 of [THRIFT-6373](https://issues.apache.org/jira/browse/THRIFT-6373) `build/cmake/README-MSYS2.md` described a build that had fallen behind: - It used the MINGW64 environment, which MSYS2 is phasing out. - It passed `-DWITH_SHARED_LIB=OFF -DWITH_STATIC_LIB=ON`, which CMake reports as deprecated, and `-DWITH_PERL=OFF`, which is not a CMake option. - It turned libevent off with a note that it does not work. - It named a 2016 MSYS2 distribution as the tested version. The instructions now follow the AppVeyor MINGW job (`build/appveyor/MINGW-appveyor-full.bat`), which builds and tests this setup on every commit: - They work in a UCRT64 terminal instead of adding `/mingw64/bin` to `~/.bash_profile`. - They install the UCRT64 packages the job installs, libevent included. - They pass the job's compiler, make and OpenSSL paths to CMake. - A sentence says what that builds, and how to get static libraries instead: `-DBUILD_SHARED_LIBS=OFF`, which replaces the deprecated options. - The pointer to THRIFT-4046, fixed in 0.11.0, is gone. - "Tested With" now names the AppVeyor job. The recipe is the one the job ran in PR #3954: builds [54793919](https://ci.appveyor.com/project/ApacheSoftwareFoundation/thrift/builds/54793919) and [54794034](https://ci.appveyor.com/project/ApacheSoftwareFoundation/thrift/builds/54794034). They used the same packages and the UCRT64 compilers, and passed all 58 tests, `TNonblockingServerTest` and `TNonblockingSSLServerTest` among them. Two differences: - The job does not pass `-DWITH_JAVA=OFF`, but it ends up with Java off as well. - It sets the PATH through `~/.bash_profile`, because it drives bash from cmd, rather than through a UCRT64 terminal. This change only edits the text of a documentation file, so under AGENTS.md §7 it runs no CI. 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
