slachiewicz opened a new pull request, #3971: URL: https://github.com/apache/thrift/pull/3971
The Go `-remote` stub's `main()` declares locals such as `client`, `cmd` and `host`, which shadowed an imported package of the same name, so the stub did not compile. The generator now reserves those names before rendering imports, so such a package is imported under an alias (for example `client0`) in every file of that program; nothing changes when `-remote` stubs are skipped. Programs that hit this also see generated temporaries renumbered, since allocating the alias uses the same counter. lib/go/test gains a service whose arguments come from packages named `client` and `host`. Verified: `make -C lib/go check`, `make -C test/go check` and `make dist` pass; Apache Accumulo's generated Go, `-remote` stubs included, now builds (its hyphenated compaction-coordinator.thrift also needs #3968). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
