slachiewicz opened a new pull request, #3970: URL: https://github.com/apache/thrift/pull/3970
A generated constructor marked a primitive field as set by calling the public, overridable `setXIsSet(true)`, which javac 21 and later report as `this-escape`. The constructor now sets the bit directly, as that method does, so there is nothing to suppress. CI builds lib/java with JDK 17, which has no this-escape lint, so the check below was run locally. Verified: the Java generated for ThriftTest, DebugProtoTest, OptionalRequiredTest, ManyOptionals, JavaTypes and the IDL from the ticket compiles with `javac 21 -Xlint:this-escape -Werror` (56 warnings before); `gradle test` in lib/java → 377 passed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
