Jens-G opened a new pull request, #3965: URL: https://github.com/apache/thrift/pull/3965
A one-line comment fix in `build/cmake/DefineOptions.cmake`. It is trivial, so it has no Jira ticket. The comment above `DEFAULT_BUILD_SHARED_LIBS` said "Default on Windows is static, shared mode library support needs work...". The first part stopped being true with 1e243a76b (2020). That commit made shared libraries the default on Windows and static libraries the default elsewhere, but left the comment. The comment now says what the code does. The second part does not hold either: both AppVeyor jobs build shared libraries on Windows and pass their tests. In [54794034](https://ci.appveyor.com/project/ApacheSoftwareFoundation/thrift/builds/54794034), MSVC ran 69 of 69 tests with `thriftmd.dll` and friends, and MinGW ran 58 of 58 with `libthrift.dll`. 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
