Sylwester Lachiewicz created THRIFT-6380:
--------------------------------------------

             Summary: Source tarball contains configure and build output 
(config.h, Makefiles, lib/d/src/base.o)
                 Key: THRIFT-6380
                 URL: https://issues.apache.org/jira/browse/THRIFT-6380
             Project: Thrift
          Issue Type: Bug
          Components: Build Process
    Affects Versions: 0.25.0, 0.24.0
            Reporter: Sylwester Lachiewicz
             Fix For: 0.26.0


thrift-0.25.0.tar.gz (and 0.24.0 before it) contains files that configure, the 
build and rebar3 produced in the release manager's tree:

* {{lib/d/src/base.o}}, a 260 KB x86-64 ELF object; ASF release policy says a 
source package should not contain compiled code
* {{config.h}} and 25 configured {{Makefile}}s next to their {{Makefile.in}}, 
carrying {{abs_top_srcdir = /thrift/src}}
* {{test/erl/_build/}} and {{test/erl/rebar.lock}}
* an empty {{lib/go/thrift/lib/go/}} directory

They get in because several Makefile.am files name whole directories in 
{{EXTRA_DIST}} (lib/d: {{src test}}), and the root {{dist-hook}} removes only 
VCS, IDE and Python leftovers. 
[THRIFT-790|https://issues.apache.org/jira/browse/THRIFT-790] fixed the 
configured Makefiles in 2010; they came back through the whole-directory 
entries.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to