Jens-G commented on PR #3952: URL: https://github.com/apache/thrift/pull/3952#issuecomment-5846802586
### Code review No blocking issues found. Checked for bugs and CLAUDE.md compliance. I ran `service_extends.test.mjs` against this head: all 12 assertions pass with code generated by this head's compiler, while with the master compiler the esm variant fails to load with `require is not defined in ES module scope`. A parent service from an included `.thrift` file (`extends IncBase.IncBase`, generated with `-r`) loads as well. One suggestion, below the bar for an issue but verified: - A small formality: the commit carries a `Generated-by:` trailer, but the PR description does not mention the AI assistance. CONTRIBUTING.md recommends the label in commits and pull requests. https://github.com/apache/thrift/blob/9fe2394e4511fcf8dbf724e63c1bc67cdbe355e3/CONTRIBUTING.md#L116-L119 🤖 Generated with [Claude Code](https://claude.ai/code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
