slachiewicz commented on PR #3821: URL: https://github.com/apache/thrift/pull/3821#issuecomment-5655951967
Branch rewritten (70cae7bfb): rebased on current master, which carries the upgrade-listener fix from 31f5897cb, so point 1 needs nothing here as you said. The suggestion is taken: both `new URL()` calls now use the fixed base `http://localhost`, so a `Host` header that is not a valid authority no longer turns into a 400. The comment cleanup from #3819 (`Buffer.from(string)` in `thrift_4987_xhr_protocol.test.mjs`) rides along. Verified: `web_server_ws.test.js` → 10 passed on the rebased branch; `eslint lib/nodejs/test` clean. *This comment was created with AI assistance.* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
