slachiewicz commented on PR #3844: URL: https://github.com/apache/thrift/pull/3844#issuecomment-5655811810
Yes, that answers it, thanks. The Framework base was exactly that relic: the C++ build uses the separately installed Build Tools, and the only thing still needed from a Framework SDK is the 4.7.2 targeting pack for the C++/CLI test project, which is now a Build Tools component. One coupling to note for November: every lib/netstd project tops out at net10.0, and the SDK 10 image cannot build a net11 target. When you add net11, the FROM line in build/docker/msvc/Dockerfile must move to mcr.microsoft.com/dotnet/sdk:11.0 in the same change. Branch rewritten: the two commits are squashed into one, rebased on current master (which picks up the TNonblockingServerTest fix from THRIFT-6244 that caused the AppVeyor failure here), and a comment next to `FROM` records the SDK/TargetFramework coupling. No other change to the diff. *This comment was created with AI assistance.* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
