Jens-G commented on PR #3823: URL: https://github.com/apache/thrift/pull/3823#issuecomment-5634701237
### Code review Found 1 issue: 1. The commit has no AI attribution trailer, although the PR description says the change was created with AI assistance (AGENTS.md says "**Always** label AI-assisted commits and PRs. Use one or both of: `Co-Authored-By: <AI tool name and version>` / `Generated-by: <AI tool name and version>`"). The PR text names no tool or version either. Your earlier generator commits for THRIFT-2063 and THRIFT-6175 carry such a trailer. https://github.com/apache/thrift/blob/aed6b47d3f31f219420297ebb104711c459c644a/AGENTS.md#L60-L74 One suggestion, below the bar for the list above but verified: - This changes what generated code produces: `String()`, and with it `MarshalText`/JSON, of an unknown value, plus a new exported `IsDefined()` on every enum. For THRIFT-2063, THRIFT-6175 and THRIFT-6195 you added a "A note about …" section to lib/go/README.md for comparable generated-code changes; a short note here would keep that consistent. https://github.com/apache/thrift/blob/aed6b47d3f31f219420297ebb104711c459c644a/lib/go/README.md#L141-L143 🤖 Generated with [Claude Code](https://claude.ai/code) <sub>- If this code review was useful, please react with 👍. Otherwise, react with 👎.</sub> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
