Jens-G commented on PR #3817:
URL: https://github.com/apache/thrift/pull/3817#issuecomment-5635255115
### Code review
No issues found. Checked for bugs and CLAUDE.md compliance.
One related case that fits THRIFT-6200 but is not covered by this change:
the container/exception branch of `generate_service_remote` still qualifies the
args constructor with `package_name_aliased`. Since THRIFT-5002,
`func_to_service` records which service declares an inherited function, but
only its name, not its package. If that service comes from an included file,
the stub does not compile:
```thrift
// ParentA.thrift
namespace go parenta
service ParentService {
void takeList(1: list<i32> xs),
}
// ChildB.thrift
include "ParentA.thrift"
namespace go childb
service ChildService extends ParentA.ParentService {
}
```
```
child_service-remote.go:163:30: undefined:
childb.NewParentServiceTakeListArgs
```
That is with the compiler built from this branch. `map`, `list<struct>` and
exception arguments fail the same way, while enum and struct arguments
inherited this way do compile. The services in `IncludesTest.thrift` do not
reach this branch, because the functions they inherit from other files take no
container arguments. Qualifying `containerStruct` with the package of the
declaring service would fix it.
https://github.com/apache/thrift/blob/ca1d1487b6dc281cd47f7f45c05c84acf234ccdf/compiler/cpp/src/thrift/generate/t_go_generator.cc#L3027-L3030
🤖 Generated with [Claude Code](https://claude.ai/code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
