Jens-G commented on PR #3819:
URL: https://github.com/apache/thrift/pull/3819#issuecomment-5634151648

   ### Code review
   
   No issues found. Checked for bugs and CLAUDE.md compliance.
   
   One minor suggestion: in `thrift_4987_xhr_protocol.test.mjs` the quoted 
statement now reads `Buffer.from(data || buf)`, but the sentence right below it 
still explains the behaviour in terms of `new Buffer(string)`. The UTF-8 
explanation holds for `Buffer.from(string)` as well, so only the name needs 
updating.
   
   
https://github.com/apache/thrift/blob/1609e5111510747057ae7b07345152f5aa828d9c/lib/nodejs/test/thrift_4987_xhr_protocol.test.mjs#L44-L49
   
   🤖 Generated with [Claude Code](https://claude.ai/code)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to