Jens-G commented on PR #3816:
URL: https://github.com/apache/thrift/pull/3816#issuecomment-5634151279
### Code review
No blocking issues found. Checked for bugs and CLAUDE.md compliance.
One suggestion, below the bar for an issue but verified:
- 30 minutes also cuts off runs that currently pass. The table in the
description covers the last five green master runs. Looking at `build.yml` runs
from 2026-09-02 to 2026-09-11 instead, several jobs succeeded after more than
30 minutes because an apt-get step stalled on the package mirror:
- `cross-test (rb, java,kotlin)`: 34 min, 33 of them in "Install openssl
and certificates" ([run
34139215123](https://github.com/apache/thrift/actions/runs/34139215123), push
to master)
- `lib-java-kotlin`: 37 min, 33 of them in "Install dependencies" ([run
33613699571](https://github.com/apache/thrift/actions/runs/33613699571))
- `lib-erl (26.2, 3.27.0)`: 41 min, nearly all of it in "Install
dependencies" ([run
34137352657](https://github.com/apache/thrift/actions/runs/34137352657))
With this change those runs fail and need a re-run. These numbers may help
with the per-job values you asked about.
https://github.com/apache/thrift/blob/3074a90d44be96df7c9475e7ac4bd4cf80ca42cd/.github/workflows/build.yml#L1200-L1202
🤖 Generated with [Claude Code](https://claude.ai/code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
