Jens Geyer created THRIFT-6228:
----------------------------------
Summary: C++: TFramedTransport::DEFAULT_MAX_FRAME_SIZE is unused
and disagrees with TConfiguration
Key: THRIFT-6228
URL: https://issues.apache.org/jira/browse/THRIFT-6228
Project: Thrift
Issue Type: Improvement
Components: C++ - Library
Reporter: Jens Geyer
{{TFramedTransport}} still declares
{code:cpp}
static const int DEFAULT_MAX_FRAME_SIZE = 256 * 1024 * 1024;
{code}
({{TBufferTransports.h:350}}), but nothing in the library, its tests or the
tutorial reads it. All three constructors take {{maxFrameSize_}} from
{{configuration_->getMaxFrameSize()}}, which defaults to
{{TConfiguration::DEFAULT_MAX_FRAME_SIZE}}, 16384000 -- so the header names a
default 16 times larger than the one in effect. The constant is public, which
is why changing or removing it was kept out of THRIFT-6183.
Suggested: mark it deprecated with a comment pointing at
{{TConfiguration::DEFAULT_MAX_FRAME_SIZE}}, and remove it in a later release.
_Drafted with AI assistance (Claude Opus 5); reviewed and filed by Jens Geyer._
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
