slachiewicz opened a new pull request, #3834:
URL: https://github.com/apache/thrift/pull/3834
Follow-up to #3820, addressing the two review comments there. Every entry
was checked against the source at 5c5e93e1e; nothing here is carried over from
the earlier matrix.
| Entry | Was | Now | Evidence |
|---|---|---|---|
| Java SE levels | 11 / 19 | 8 / 17 | `build.yml` builds on JDK 17 and runs
the cross-tests on Java 8; `sourceConfiguration.gradle` sets a JDK 17 toolchain
with `options.release = 8` |
| Rust TLS | no | yes | the `rustls` feature in `Cargo.toml`, with
`TTlsClientChannel::connect` and `TServer::listen_tls` |
| Rust Domain | no | yes | `TServer::listen_uds`, under `#[cfg(unix)]` |
| Rust ThreadPool | no | yes | `TServer` holds a `ThreadPool` sized by
`num_workers` |
| Python Memory, Framed | no | yes | `TMemoryBuffer` and `TFramedTransport` |
| Python Threaded, ThreadPool | no | yes | `TThreadedServer` and
`TThreadPoolServer` |
| Kotlin level | 1.8 | 2.4.10 | `settings.gradle.kts` uses `kotlin("jvm")
version "2.4.10"`; 1.8 is the bytecode target, not the Kotlin version |
| Kotlin Multiplex, zlib, Nonblocking, ThreadPool | no | yes | the
cross-test server uses `TMultiplexedProcessor`, `TZlibTransport`,
`TNonblockingServer` and `TThreadPoolServer` over the Java runtime |
| Haxe Memory | no | yes | `TMemoryStream`, with round-trip coverage in
`StreamTest.hx` |
The table has no way to carry a condition, so this adds a short notes
section for three of them: the `rustls` feature is off by default, `listen_uds`
is Unix-only, and the Java and Kotlin rows report tested bounds rather than a
maximum supported release.
One entry is deliberately left alone. Rust has a single server type, a
fixed-size worker pool, and the row marks it as both Threaded and ThreadPool.
Marking ThreadPool is right; whether Threaded should stay is a separate
judgement, and I did not want to fold it into a corrections PR.
Thanks @HTHou for the two lists. The claims held up on inspection.
*This change was created with AI assistance.*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
