[
https://issues.apache.org/jira/browse/THRIFT-5379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sylwester Lachiewicz resolved THRIFT-5379.
------------------------------------------
Resolution: Fixed
Fixed by
[2853af2d0|https://github.com/apache/thrift/commit/2853af2d02dc1c4e42175e76d5ccefe9e797c4c4]
("Compile TWebSocketServer with CMake only when OpenSSL is found",
2021-10-20), first released in 0.16.0.
The break came from
[1ab096c80|https://github.com/apache/thrift/commit/1ab096c80af1a2bca73aef78675de914a1834fd9]
(THRIFT-5185, 0.14), which added {{TWebSocketServer.cpp}} to the unconditional
source list in
[lib/cpp/CMakeLists.txt|https://github.com/apache/thrift/blob/master/lib/cpp/CMakeLists.txt];
that file includes OpenSSL headers, so a build with OpenSSL disabled failed to
compile. The fix moved it inside the {{if(OPENSSL_FOUND AND WITH_OPENSSL)}}
block, where it still sits today alongside {{TSSLSocket.cpp}} and
{{TSSLServerSocket.cpp}}.
Verified against master: {{cmake -DWITH_OPENSSL=OFF -DBUILD_COMPILER=OFF
-DBUILD_TESTING=OFF}} followed by {{cmake --build . --target thrift}}
configures, compiles and links libthrift with no OpenSSL dependency.
Resolving as Fixed with fixVersion 0.16.0.
> fix cmake support to build cpp server without OPENSSL
> -----------------------------------------------------
>
> Key: THRIFT-5379
> URL: https://issues.apache.org/jira/browse/THRIFT-5379
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
> Affects Versions: 0.14.1
> Reporter: Kurt Johnson
> Priority: Minor
> Fix For: 0.16.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Very similar to issue THRIFT-5047
>
> In 0.14 a new transport was added that broke the ability to compile without
> openssl. Fix the cmake file to allow compiling without openssl.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
