[
https://issues.apache.org/jira/browse/THRIFT-3972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sylwester Lachiewicz resolved THRIFT-3972.
------------------------------------------
Resolution: Fixed
The NoStarveReadWriteMutex implementation this race was reported against no
longer exists — the C++11 concurrency rework (THRIFT-4720) replaced the mutex
stack with std-based primitives
([lib/cpp/src/thrift/concurrency/Mutex.h|https://github.com/apache/thrift/blob/master/lib/cpp/src/thrift/concurrency/Mutex.h]).
Resolving as Fixed.
> C++ Library NoStarveReadWriteMutex helgrind identified race
> -----------------------------------------------------------
>
> Key: THRIFT-3972
> URL: https://issues.apache.org/jira/browse/THRIFT-3972
> Project: Thrift
> Issue Type: Improvement
> Components: C++ - Library
> Affects Versions: 0.10.0
> Reporter: James E. King III
> Priority: Minor
>
> An issue from THRIFT-3038 was split out so it could be completed.
> There is a class in the project called NoStarveReadWriteMutex which is unused
> in the project.
> It has a unit test (RWMutexStarveTest).
> helgrind identified that there is a race in the handling of the volatile
> boolean in this class.
> I would prefer to just remove NoStarveReadWriteMutex as it is not used by the
> project, however doing so would require refactoring the RWMutexStarveTest
> because it ends up testing ReadWriteMutex, which is used by something in
> {{contrib/fb303}}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
