[ 
https://issues.apache.org/jira/browse/THRIFT-793?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sylwester Lachiewicz resolved THRIFT-793.
-----------------------------------------
    Fix Version/s: 0.13.0
       Resolution: Fixed

{{socket.gaierror}} on open() has been wrapped in {{TTransportException}} since 
[3131fe97|https://github.com/apache/thrift/commit/3131fe975] (the THRIFT-4904 
work, 2019): 
[TSocket.py|https://github.com/apache/thrift/blob/master/lib/py/src/transport/TSocket.py]
 wraps {{socket.error}}, {{socket.gaierror}} and {{socket.timeout}} on every 
open, read, write and listen path. First released in 0.13.0. Resolving as Fixed.

> TSocket doesn't handle socket.gaierror on open()
> ------------------------------------------------
>
>                 Key: THRIFT-793
>                 URL: https://issues.apache.org/jira/browse/THRIFT-793
>             Project: Thrift
>          Issue Type: Bug
>          Components: Python - Library
>    Affects Versions: 0.2
>         Environment: Linux & Python 2.6
>            Reporter: tholzer
>            Priority: Minor
>              Labels: TSocket, exception, gaierror, getaddrinfo, open, socket
>             Fix For: 0.13.0
>
>
> Inside TSocket open(), _resolveAddr() calls getaddrinfo() which can throw 
> socket.gaierror:
> {noformat}
> try:
>   res0 = self._resolveAddr()
>   ...
> except socket.error, e:
>   ...
>   raise TTransportException(TTransportException.NOT_OPEN, message)
> {noformat}
> This needs to be caught by the exception handler and translated into an 
> appropriate TTransportException with as much detail as possible about the 
> original socket.gaierror.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to