[
https://issues.apache.org/jira/browse/THRIFT-4732?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sylwester Lachiewicz resolved THRIFT-4732.
------------------------------------------
Fix Version/s: 0.13.0
Resolution: Fixed
Resolving. {{CMakeLists.txt}} requires CMake 3.16, well past the 3.4-3.5
discussed on this ticket, and the script cleanup landed with it in
{{a6a3a787e}}.
The reporter confirmed "yes" to "Is this one complete yet?" on 10 February
2019; the ticket was simply never closed. First released in 0.13.0.
_This comment was created with AI assistance._
> increase cmake minimal required version and cleanup cmake scripts
> -----------------------------------------------------------------
>
> Key: THRIFT-4732
> URL: https://issues.apache.org/jira/browse/THRIFT-4732
> Project: Thrift
> Issue Type: Improvement
> Components: Build Process
> Reporter: yuanyuan chen
> Priority: Major
> Fix For: 0.13.0
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> In order to use modern cmake syntax to cleanup building scripts and add
> shared library support on Windows by using [[windows_export_all_symbol|
> https://cmake.org/cmake/help/v3.13/prop_tgt/WINDOWS_EXPORT_ALL_SYMBOLS.html].|https://cmake.org/cmake/help/v3.13/prop_tgt/WINDOWS_EXPORT_ALL_SYMBOLS.html]
> So I think it is a good idea to increase cmake minimal required version.May
> be 3.10 is a good alternative version?
> h1.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
