[
https://issues.apache.org/jira/browse/THRIFT-6196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sylwester Lachiewicz resolved THRIFT-6196.
------------------------------------------
Fix Version/s: 0.25.0
Resolution: Fixed
Fixed in master by commit 7d1df1e34df601cc235d03ea8ad3c4eee0955f3b (PR #3789).
The commit subject omits the issue key, so this link is the only pointer from
the ticket to the change.
> Remove the unreleased contrib thrift-maven-plugin in favour of standard Maven
> plugins
> -------------------------------------------------------------------------------------
>
> Key: THRIFT-6196
> URL: https://issues.apache.org/jira/browse/THRIFT-6196
> Project: Thrift
> Issue Type: Improvement
> Components: Build Process, Java - Library
> Reporter: Sylwester Lachiewicz
> Assignee: Sylwester Lachiewicz
> Priority: Major
> Fix For: 0.25.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The {{contrib/thrift-maven-plugin}} tree has not been released, is not wired
> into the main build, and duplicates functionality that standard Maven plugins
> already provide. Its two mojos shell out to the {{thrift}} binary and
> register the output directory as a source root, which is what
> {{exec-maven-plugin}} and {{build-helper-maven-plugin}} do out of the box.
> Keeping it carries ongoing cost. THRIFT-issue aside, PR #3347 attempted to
> build and publish the plugin from CMake and autotools and stalled on an MSVC
> failure in {{ThriftMavenPluginTest}}; on that PR ctubbsii proposed deleting
> the plugin rather than complicating the main build with it, and Jens-G set
> the PR to draft pending a decision.
> Proposed:
> * remove {{contrib/thrift-maven-plugin}}
> * document the {{exec-maven-plugin}} + {{build-helper-maven-plugin}}
> equivalent in {{lib/java/README.md}}
> * drop the plugin's {{pom.xml}} from {{build/veralign.sh}}
> PR: https://github.com/apache/thrift/pull/3789
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
