slachiewicz opened a new pull request, #3808: URL: https://github.com/apache/thrift/pull/3808
Fixes THRIFT-5493, open since 2022. `test/go/genmock.sh` ends with `chmod a+w -R $GOPATH && rm -Rf $GOPATH`. BSD `chmod`, macOS included, takes the first non-option argument as a file name, so the command fails with `chmod: -R: No such file or directory`. The script runs under `set -e`, so it exits there and leaves the temporary GOPATH behind. GNU `chmod` permutes its arguments, which is why CI on Ubuntu never saw it. The path is quoted at the same time, since it comes from `mktemp`. Verified: on macOS, `chmod a+w -R <dir>` exits 1 with that error and `chmod -R a+w <dir>` exits 0; `sh -n test/go/genmock.sh` passes. *This change was created with AI assistance.* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
