Sylwester Lachiewicz created THRIFT-6196:
--------------------------------------------
Summary: Remove the unreleased contrib thrift-maven-plugin in
favour of standard Maven plugins
Key: THRIFT-6196
URL: https://issues.apache.org/jira/browse/THRIFT-6196
Project: Thrift
Issue Type: Improvement
Components: Java - Library, Build Process
Reporter: Sylwester Lachiewicz
Assignee: Sylwester Lachiewicz
The {{contrib/thrift-maven-plugin}} tree has not been released, is not wired
into the main build, and duplicates functionality that standard Maven plugins
already provide. Its two mojos shell out to the {{thrift}} binary and register
the output directory as a source root, which is what {{exec-maven-plugin}} and
{{build-helper-maven-plugin}} do out of the box.
Keeping it carries ongoing cost. THRIFT-issue aside, PR #3347 attempted to
build and publish the plugin from CMake and autotools and stalled on an MSVC
failure in {{ThriftMavenPluginTest}}; on that PR ctubbsii proposed deleting the
plugin rather than complicating the main build with it, and Jens-G set the PR
to draft pending a decision.
Proposed:
* remove {{contrib/thrift-maven-plugin}}
* document the {{exec-maven-plugin}} + {{build-helper-maven-plugin}} equivalent
in {{lib/java/README.md}}
* drop the plugin's {{pom.xml}} from {{build/veralign.sh}}
PR: https://github.com/apache/thrift/pull/3789
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
