slachiewicz commented on PR #3788: URL: https://github.com/apache/thrift/pull/3788#issuecomment-5560967344
Thank you fishy for the review comment. I've implemented the requested test case for the fast path in and the Go tests. The new commit includes: - struct exercising every accepted scalar kind (bool, i8, i16, i32, i64, double, string) plus an enum — this pins the linear -map duplicate check path - (binary field) and (optional → pointer field) — exercise the pairwise Equals scan with a plain struct key (not just unions) - — tests typedef-of-union resolution - New table-driven duplicate rejection across all key shapes and distinct-key acceptance - Nil-key parity on the pairwise branch (single nil ok, two nils rejected) You can view the full diff at the PR: https://github.com/apache/thrift/pull/3788/files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
