Jens-G commented on PR #3792: URL: https://github.com/apache/thrift/pull/3792#issuecomment-5516719417
### Code review Found 3 issues: 1. `"readme": "README.md"` is removed. The PR is presented as a formatting cleanup, but this is a content change that neither the title nor the description mentions. The practical effect is nil -- Packagist auto-detects `README.md` for GitHub-hosted packages -- but the key was added deliberately in [384647d29](https://github.com/apache/thrift/commit/384647d290e2e4a55a14b1b7ef1b7e66293a2c33) ("Version 0.12.0"). https://github.com/apache/thrift/blob/b8da62ac3e4da60cbf73cb9aea35a1bf59cdd82c/composer.json#L7-L9 2. `"minimum-stability": "stable"` is removed. The same commit set this deliberately, changing it from `"dev"` to `"stable"` as part of making the PHP package release-ready. Composer's default is already `stable`, so behaviour does not change, but the explicit declaration goes away without a note. https://github.com/apache/thrift/blob/b8da62ac3e4da60cbf73cb9aea35a1bf59cdd82c/composer.json#L58-L60 3. `authors[0].homepage` is removed. Present since the file was first added; it drops the author-block link Packagist renders. Cosmetic, but likewise undisclosed. https://github.com/apache/thrift/blob/b8da62ac3e4da60cbf73cb9aea35a1bf59cdd82c/composer.json#L12-L14 Each is harmless on its own. The ask is to either restore them or name them in the PR description, so that a reformat PR reviews as a reformat. The `require`/`require-dev` sets, autoload paths and `archive.exclude` are unchanged, and the 4-to-2-space reindent brings the file in line with `.editorconfig`'s `[*.json] indent_size = 2`. 🤖 Generated with [Claude Code](https://claude.ai/code) <sub>- If this code review was useful, please react with 👍. Otherwise, react with 👎.</sub> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
