Jens-G opened a new pull request, #3768:
URL: https://github.com/apache/thrift/pull/3768
`lib/haxe/src/org/apache/thrift/transport/TFullDuplexHttpClient.hx` has
never been compiled by anyone, on any target.
### It is compiled out everywhere
The body is wrapped in `#if swf`. The Haxe Flash target defines `flash`, not
`swf`, so the guard never holds. Verified both ways with Haxe 4.2.1: a `#if
swf` block containing a deliberate type error compiles clean under `-swf`
(skipped), while the same block written `#if flash` fails with the expected
error.
### It would not compile if the guard were corrected
Changing the guard to `#if flash` and building for `-swf` gives, in order:
- l.181 `Type not found : Function`
- l.240 `Type not found : Error`
- `new Bytes()` (for `obuffer`, `CRLF`, and `chunkSize`) — `Not enough
arguments, expected length:Int, b:haxe.io.BytesData`
- `chunkSize.writeByte(...)` — `haxe.io.Bytes` has no `writeByte`
### Context
Added by THRIFT-2644 (2014) as a port of the ActionScript 3 library
(THRIFT-1223 / THRIFT-2391). Referenced nowhere else in the tree, absent from
every build file, not exercised by CI. `haxelib.json` publishes `src/` via
`classPath`, so it shipped in the haxelib package without ever being built.
Adobe Flash reached end of life on 2020-12-31.
Related but unaffected: THRIFT-669 asks for chunk-encoded full-duplex HTTP
in the **Java** library.
### Verification
Force-compiling the whole package with `--macro include('org.apache.thrift',
true)` succeeds identically before and after the removal, on `swf`, `neko`,
`python`, `js` and `php` — the class contributed nothing to any of them. No
build file changes are needed.
---
Generated-by: Claude Opus 5
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
