sveneld opened a new pull request, #3765:
URL: https://github.com/apache/thrift/pull/3765
Fixes the remaining `php->cpp` HTTP cross-test failures on current `master`
after `THRIFT-6023` and `THRIFT-6060` landed.
Changes:
- add `Content-Length` to synchronous responses from
`test/php/HttpServer.php` so the C++ HTTP client can consume PHP HTTP replies
correctly
- preserve the PHP launcher flags when `test/php/HttpRouter.php` execs into
`php -S`
- remove the now-passing `php-cpp_{binary,compact,json}_http-ip` cases from
`test/known_failures_Linux.json`
Validation:
- `php->cpp` HTTP: `binary`, `compact`, `json`
- `cpp->php` HTTP: `binary`, `compact`, `json`, `multi-binary`,
`multic-compact`, `multij-json`
JIRA: `THRIFT-6167`
Generated-by: OpenAI Codex GPT-5
- [x] Did you create an [Apache
Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket?
`THRIFT-6167`
- [x] If a ticket exists: Does your pull request title follow the pattern
"THRIFT-NNNN: describe my issue"?
- [x] Did you squash your changes to a single commit?
- [x] Did you do your best to avoid breaking changes? If one was needed, did
you label the Jira ticket with "Breaking-Change"?
- [ ] If your change does not involve any code, include `[skip ci]` anywhere
in the commit message to free up build resources.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
