Jens-G opened a new pull request, #3756: URL: https://github.com/apache/thrift/pull/3756
Only the first two calls in `StreamTest.Run()` leave the temp file behind, and every step after them runs once it has already been deleted. The `catch` block deleted it unconditionally, so any failure past that point surfaced as `std@file_delete` instead of the assertion that actually failed. ### Demonstration Injecting a failing assertion after the deletion point, same injected failure both times: | | Reported error | |---|---| | before | `std@file_delete` | | after | `Test "INJECTED FAILURE" failed at Run in src/tests/StreamTest.hx:143` | ### Notes Test-only change; no library code is touched. Found while adding tests elsewhere in this file, where it hid a genuinely failing case until the cause was tracked down. Verified on neko (full suite); no ticket, as a test-harness tidy-up under the "minor / quick fixes" heading in `AGENTS.md` §2. 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
