jaipaulcheernam commented on PR #3752:
URL: https://github.com/apache/thrift/pull/3752#issuecomment-5451756177
> Is it expected that SecurityTest and SecurityFromBufferTest both
hang/timeout with OpenSSL 4.0.2 and the test expectations will be changed in a
future pull request?
>
> `OPENSSL_NO_SSL3` is not defined for OpenSSSL 4 so `#ifdef
OPENSSL_NO_SSL3` passes and the tests try to use SSL3 and timeout. TLSv1.0/1.1
require `SSL_CTX_set_min_proto_version` when using TLS_method instead of the
per version method. Without it being set the TLSv1.0 and TLSv1.1 tests timeout
like the SSL 3 tests.
Thanks for the feedback! Updated the PR:
- Rebased onto latest master (conflicts resolved)
- TLSv1.0/1.1/1.2 now use TLS_method() + SSL_CTX_set_min_proto_version() /
SSL_CTX_set_max_proto_version() on OpenSSL 4.0, so tests should no longer hang
- SSLv3 is guarded out on OpenSSL 4.0 (returns error since the protocol is
truly removed)
- ERR_remove_state() calls removed (no-op since OpenSSL 1.1)
I haven't been able to run the SecurityTest/SecurityFromBufferTest locally
— if there are still test timeouts, happy to iterate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
