Copilot commented on code in PR #3747:
URL: https://github.com/apache/thrift/pull/3747#discussion_r3843715575
##########
lib/ts/package.json:
##########
@@ -37,6 +37,9 @@
"grunt-legacy-log": "3.0.1",
"grunt-legacy-log-utils": "2.1.3",
"grunt-legacy-util": "2.0.2",
+ "grunt-contrib-qunit": {
+ "puppeteer": "25.8.0"
+ },
Review Comment:
This override pins `grunt-contrib-qunit`'s Puppeteer to 25.8.0, which
requires Node.js >=22.12.0. To prevent confusing install/runtime failures for
contributors on older Node versions, consider encoding this in `package.json`
(e.g., an `engines.node` constraint) or otherwise making the minimum Node
version requirement explicit in this package.
##########
lib/ts/test/build.xml:
##########
@@ -100,10 +100,10 @@
<target name="download_jslibs">
<get src="http://code.jquery.com/jquery-1.11.3.min.js";
dest="${build}/js/lib/jquery.js" usetimestamp="true"/>
- <get src="http://code.jquery.com/qunit/qunit-2.6.2.js";
dest="${build}/js/lib/qunit.js" usetimestamp="true"/>
- <get src="http://code.jquery.com/qunit/qunit-2.6.2.css";
dest="${build}/js/lib/qunit.css" usetimestamp="true"/>
- <get src="http://code.jquery.com/qunit/qunit-2.6.2.js";
dest="${build}/ts/qunit.js" usetimestamp="true"/>
- <get src="http://code.jquery.com/qunit/qunit-2.6.2.css";
dest="${build}/ts/qunit.css" usetimestamp="true"/>
+ <get src="https://code.jquery.com/qunit/qunit-2.26.0.js";
dest="${build}/js/lib/qunit.js" usetimestamp="true"/>
Review Comment:
`download_jslibs` still fetches jQuery over plain HTTP
(`http://code.jquery.com/...`). That makes the test build dependent on an
insecure transport and can fail in environments that block HTTP. Please switch
this URL to HTTPS (and ideally keep all external asset downloads consistent).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
