kpumuk commented on code in PR #3744:
URL: https://github.com/apache/thrift/pull/3744#discussion_r3843027013
##########
lib/rb/lib/thrift/protocol/json_protocol.rb:
##########
@@ -548,7 +548,11 @@ def read_json_base64
str += "="
end
end
- str.unpack1("m0")
+ begin
+ str.unpack1("m0")
+ rescue ArgumentError
+ raise ProtocolException.new(ProtocolException::INVALID_DATA, "Invalid
Base64 data")
+ end
Review Comment:
This is a solid observation, but a larger scope than current bug. Created
https://issues.apache.org/jira/browse/THRIFT-6158 to follow-up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
