Copilot commented on code in PR #3742: URL: https://github.com/apache/thrift/pull/3742#discussion_r3840091307
########## lib/rb/README.md: ########## @@ -144,6 +144,11 @@ mount Thrift::RackApplication.new(processor) => "/thrift" ### 0.25.0 +Ruby 2.7 support has been removed because the runtime reached end of life on +March 31, 2023. The Thrift gem now requires Ruby 3.0 or newer. Applications +still running Ruby 2.7 must upgrade Ruby before installing Thrift 0.25.0 or +remain on an earlier Thrift release. Review Comment: This README update raises the minimum supported Ruby to 3.0, but later in the same file the 0.23.0 breaking-changes section still states that the source-build flow "requires Ruby `2.7+`" and cites `json-2.18.1` requiring Ruby >= 2.7 (README.md:237-240). That is now inconsistent with the gem’s declared minimum (3.0) and may confuse readers; please update those older notes accordingly (or clarify they refer to historical 0.23.0 constraints). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
