kpumuk commented on code in PR #3717:
URL: https://github.com/apache/thrift/pull/3717#discussion_r3792030406
##########
lib/rb/.rubocop.yml:
##########
@@ -9,24 +9,94 @@ AllCops:
Exclude:
- "**/vendor/**/*"
+Layout/ArgumentAlignment:
+ Enabled: true
+
+Layout/ArrayAlignment:
+ Enabled: true
+
+Layout/BlockAlignment:
+ Enabled: true
+ EnforcedStyleAlignWith: start_of_block
+
+Layout/CaseIndentation:
+ Enabled: true
+ EnforcedStyle: end
+
+Layout/ClosingParenthesisIndentation:
+ Enabled: true
+
+Layout/CommentIndentation:
+ Enabled: true
+
Layout/EmptyLines:
Enabled: true
Layout/EmptyLinesAroundBlockBody:
Enabled: true
+Layout/ElseAlignment:
+ Enabled: true
+
+Layout/EndAlignment:
+ Enabled: true
+ EnforcedStyleAlignWith: variable
+
Layout/ExtraSpacing:
Enabled: true
+Layout/FirstArgumentIndentation:
+ Enabled: true
+
+Layout/FirstArrayElementIndentation:
+ Enabled: true
+ EnforcedStyle: consistent
+
+Layout/FirstArrayElementLineBreak:
+ Enabled: true
+
+Layout/FirstHashElementIndentation:
+ Enabled: true
+ EnforcedStyle: consistent
+
+Layout/FirstHashElementLineBreak:
+ Enabled: true
+
+Layout/FirstMethodArgumentLineBreak:
+ Enabled: true
+ AllowMultilineFinalElement: true
+
+Layout/HashAlignment:
+ Enabled: true
+ EnforcedHashRocketStyle:
+ - key
+ - table
Review Comment:
`Layout/HashAlignment` supports multiple allowed styles when
`AllowMultipleStyles` is enabled, which is the default for this cop. RuboCop
1.82.1 accepts this list and evaluates both `key` and `table` alignment
strategies. This allows vertically aligned hash-rocket tables while retaining
normal key alignment elsewhere.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
