kpumuk opened a new pull request, #3716:
URL: https://github.com/apache/thrift/pull/3716

   <!-- Explain the changes in the pull request below: -->
   
   Ruby sources currently use a mixture of hash rockets and label syntax for 
symbol keys. This enables `Style/HashSyntax` and normalizes symbol-keyed hashes 
across the Ruby library and tests while continuing to allow either form of 
value shorthand.
   
   The Ruby compiler now emits label syntax for generated field metadata and 
service arguments. Hash rockets remain in generated output where keys are 
dynamic or non-symbol values.
     
   
   <!-- We recommend you review the checklist/tips before submitting a pull 
request. -->
   
   - [ ] Did you create an [Apache 
Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket?  
([Request account here](https://selfserve.apache.org/jira-account.html), not 
required for trivial changes)
   - [ ] If a ticket exists: Does your pull request title follow the pattern 
"THRIFT-NNNN: describe my issue"?
   - [x] Did you squash your changes to a single commit?  (not required, but 
preferred)
   - [x] Did you do your best to avoid breaking changes?  If one was needed, 
did you label the Jira ticket with "Breaking-Change"?
   - [ ] If your change does not involve any code, include `[skip ci]` anywhere 
in the commit message to free up build resources.
   
   <!--
     The Contributing Guide at:
     https://github.com/apache/thrift/blob/master/CONTRIBUTING.md
     has more details and tips for committing properly.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to