kpumuk opened a new pull request, #3702:
URL: https://github.com/apache/thrift/pull/3702
<!-- Explain the changes in the pull request below: -->
Ruby `MemoryBufferTransport` currently retains a caller-supplied string as
its internal storage. Mutating either object can therefore unexpectedly alter
the other, frozen input can fail during later writes or resets, and
construction can change the caller's string encoding.
This change duplicates constructor input before normalizing it to binary
encoding. The transport consequently owns a private mutable buffer: caller
mutations no longer change unread bytes, transport operations no longer modify
the caller's string, and frozen input remains usable.
This deliberately removes the historical shared-buffer behavior. Callers
that intentionally treated the original string as a live view of the transport
will instead need to read from the transport.
<!-- We recommend you review the checklist/tips before submitting a pull
request. -->
- [x] Did you create an [Apache
Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket?
[THRIFT-6138](https://issues.apache.org/jira/browse/THRIFT-6138)
- [x] If a ticket exists: Does your pull request title follow the pattern
"THRIFT-NNNN: describe my issue"?
- [x] Did you squash your changes to a single commit? (not required, but
preferred)
- [ ] Did you do your best to avoid breaking changes? If one was needed,
did you label the Jira ticket with "Breaking-Change"?
- [ ] If your change does not involve any code, include `[skip ci]` anywhere
in the commit message to free up build resources.
<!--
The Contributing Guide at:
https://github.com/apache/thrift/blob/master/CONTRIBUTING.md
has more details and tips for committing properly.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
