kpumuk commented on code in PR #3700:
URL: https://github.com/apache/thrift/pull/3700#discussion_r3707702108
##########
lib/rb/spec/struct_spec.rb:
##########
@@ -212,6 +225,27 @@ def validate_default_arguments(object)
}.to raise_error(sentinel)
end
+ [
+ ['map', Thrift::Types::MAP, 5, :read_map_begin, [Thrift::Types::I32,
Thrift::Types::MAP]],
+ ['list', Thrift::Types::LIST, 4, :read_list_begin, [Thrift::Types::I32]],
+ ['set', Thrift::Types::SET, 6, :read_set_begin, [Thrift::Types::I16]]
+ ].each do |name, field_type, field_id, begin_method, header|
Review Comment:
Foo.complex is declared as map<i32, map<string, double>>, so MAP is the
expected value type here. Using I32 would instead exercise the
type-mismatch/skip path. The focused spec passes with both native and pure Ruby
implementations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
