vikrantpuppala commented on PR #3685: URL: https://github.com/apache/thrift/pull/3685#issuecomment-5127344524
Thanks — addressed in 152b8bda2. - Replaced the `exports`-shape assertions and in-process load check with a subprocess that disables `require(esm)` when the runtime supports that flag; older Node versions naturally use their CJS-only loader. - The subprocess loads Thrift, requires `uuid`, and executes the generated-code `v4` API, so `uuid@14` now fails behaviorally even on modern CI Node. - Kept the binary/compact UUID round-trip coverage. - Documented that `11.1.1` is the deliberate `legacy-11` maintenance floor in both the commit and PR body. Validated on Node 16 and Node 24; formatting and `npm run lint-tests` pass. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
