kpumuk commented on PR #3686: URL: https://github.com/apache/thrift/pull/3686#issuecomment-5124799130
Follow-up: removed `ZLIB_INFLATE_CHUNK_SIZE`, which previously only sliced the compressed input passed to `Inflate#inflate`. One such input slice could still expand into the complete decompressed payload before `HeaderTransport` checked its limit. The streaming `Zlib::Inflate` API instead delivers decompressed output incrementally. Ruby’s current implementation emits callback chunks up to 16 KiB, and `HeaderTransport` now checks the cumulative size before appending each chunk. This avoids materializing an unbounded full inflate result in `HeaderTransport`. The configured limit remains an application-buffer limit rather than a strict process-allocation limit: Ruby Zlib may allocate its internal output chunk before invoking the callback. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
