kpumuk opened a new pull request, #3682:
URL: https://github.com/apache/thrift/pull/3682
<!-- Explain the changes in the pull request below: -->
Ruby socket transports previously left their underlying connection open when
a timed read or write raised `TIMED_OUT`. Once an operation had made partial
progress, the stream could no longer be safely reused: a read may already have
consumed response bytes, while a write may already have delivered part of a
request.
This change closes the affected transport before propagating the original
timeout. TCP, TLS, UNIX, and server-accepted socket transports now consistently
require a fresh connection after an I/O timeout, while successful operations
remain unchanged.
<!-- We recommend you review the checklist/tips before submitting a pull
request. -->
- [x] Did you create an [Apache
Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket?
[THRIFT-6127](https://issues.apache.org/jira/browse/THRIFT-6127)
- [x] If a ticket exists: Does your pull request title follow the pattern
"THRIFT-NNNN: describe my issue"?
- [x] Did you squash your changes to a single commit? (not required, but
preferred)
- [x] Did you do your best to avoid breaking changes? If one was needed,
did you label the Jira ticket with "Breaking-Change"?
- [ ] If your change does not involve any code, include `[skip ci]` anywhere
in the commit message to free up build resources.
<!--
The Contributing Guide at:
https://github.com/apache/thrift/blob/master/CONTRIBUTING.md
has more details and tips for committing properly.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
