kpumuk opened a new pull request, #3672:
URL: https://github.com/apache/thrift/pull/3672
<!-- Explain the changes in the pull request below: -->
`HeaderProtocol` previously attempted to report an unknown Header
subprotocol using the same unknown protocol identifier in its response frame.
Although the payload contained an application exception, the peer could not
select a decoder for it. The response also replaced the Header sequence ID with
zero, preventing the peer from reliably associating the error with its request.
This change writes the application exception using the configured default
Binary or Compact protocol and preserves the sequence ID parsed from the
incoming Header frame. The resulting response can be decoded by a fresh
`HeaderProtocol` and correlated with the request. If the Header itself is
malformed before a valid error response can be constructed, the original error
is raised without attempting to emit another response.
<!-- We recommend you review the checklist/tips before submitting a pull
request. -->
- [x] Did you create an [Apache
Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket?
[THRIFT-6121](https://issues.apache.org/jira/browse/THRIFT-6121)
- [x] If a ticket exists: Does your pull request title follow the pattern
"THRIFT-NNNN: describe my issue"?
- [x] Did you squash your changes to a single commit? (not required, but
preferred)
- [x] Did you do your best to avoid breaking changes? If one was needed,
did you label the Jira ticket with "Breaking-Change"?
- [ ] If your change does not involve any code, include `[skip ci]` anywhere
in the commit message to free up build resources.
<!--
The Contributing Guide at:
https://github.com/apache/thrift/blob/master/CONTRIBUTING.md
has more details and tips for committing properly.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
