SLAVONchick commented on code in PR #3666:
URL: https://github.com/apache/thrift/pull/3666#discussion_r3643642698
##########
compiler/cpp/src/thrift/generate/t_oop_generator.h:
##########
@@ -104,6 +105,27 @@ class t_oop_generator : public t_generator {
ss << " " << p->get_doc();
}
}
+
+ ss << '\n';
+
+ const std::vector<t_field*>& exceptions =
tfunction->get_xceptions()->get_members();
+ std::vector<t_field*>::const_iterator e_iter;
+ for (e_iter = exceptions.begin(); e_iter != exceptions.end(); ++e_iter) {
+ t_field* e = *e_iter;
+ std::string namespace_str =
e->get_type()->get_program()->get_namespace(lang);
+
+ if (static_cast<std::string>(lang).compare("cpp") == 0) {
Review Comment:
Totally agree, my bad. Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
