kpumuk opened a new pull request, #3656:
URL: https://github.com/apache/thrift/pull/3656
<!-- Explain the changes in the pull request below: -->
The Ruby TCP transport currently replaces its live socket when `open` is
called a second time. The original connection remains open but is no longer
reachable through the transport, so a later `close` only closes the replacement
connection.
This change rejects a duplicate open with `TransportException::ALREADY_OPEN`
while preserving the existing live connection. Callers can continue using or
explicitly close the original transport without leaving an orphaned TCP session.
The change is intentionally scoped to `Thrift::Socket`; transports that
provide their own `open` implementation are not altered.
<!-- We recommend you review the checklist/tips before submitting a pull
request. -->
- [x] Did you create an [Apache
Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket?
[THRIFT-6112](https://issues.apache.org/jira/browse/THRIFT-6112)
- [x] If a ticket exists: Does your pull request title follow the pattern
"THRIFT-NNNN: describe my issue"?
- [x] Did you squash your changes to a single commit? (not required, but
preferred)
- [x] Did you do your best to avoid breaking changes? If one was needed,
did you label the Jira ticket with "Breaking-Change"?
- [ ] If your change does not involve any code, include `[skip ci]` anywhere
in the commit message to free up build resources.
<!--
The Contributing Guide at:
https://github.com/apache/thrift/blob/master/CONTRIBUTING.md
has more details and tips for committing properly.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
