Jens-G commented on PR #3639: URL: https://github.com/apache/thrift/pull/3639#issuecomment-5028070799
### Code review Found 1 issue: 1. `configured_ssl_context` mutates the caller-supplied `ssl_context` object in place (sets `verify_mode` and, if unset, `cert_store`) with no documentation that a passed-in context will be modified. A caller that shares one `SSLContext` across multiple `SSLSocket` instances with different `verify_peer` settings, or that reuses the object after passing it in, will see its own context silently rewritten. https://github.com/apache/thrift/blob/bc2dd8fdb5b2aeecaa66b737db7de6c019a452f2/lib/rb/lib/thrift/transport/ssl_socket.rb#L90-L104 🤖 Generated with [Claude Code](https://claude.ai/code) <sub>- If this code review was useful, please react with 👍. Otherwise, react with 👎.</sub> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
