kpumuk opened a new pull request, #3641:
URL: https://github.com/apache/thrift/pull/3641
<!-- Explain the changes in the pull request below: -->
The native `MemoryBufferTransport#read_into_buffer` implementation bypassed
Ruby’s frozen-string checks. A positive-length read could therefore overwrite a
frozen destination and consume transport input, while the pure-Ruby
implementation raised `FrozenError`.
This change asks Ruby to make positive-length destination strings mutable
before reading from the transport. Frozen destinations now raise `FrozenError`
before either the destination or transport is modified, while zero-length reads
remain no-ops.
<!-- We recommend you review the checklist/tips before submitting a pull
request. -->
- [x] Did you create an [Apache
Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket?
[THRIFT-6100](https://issues.apache.org/jira/browse/THRIFT-6100)
- [x] If a ticket exists: Does your pull request title follow the pattern
"THRIFT-NNNN: describe my issue"?
- [x] Did you squash your changes to a single commit? (not required, but
preferred)
- [x] Did you do your best to avoid breaking changes? If one was needed,
did you label the Jira ticket with "Breaking-Change"?
- [ ] If your change does not involve any code, include `[skip ci]` anywhere
in the commit message to free up build resources.
<!--
The Contributing Guide at:
https://github.com/apache/thrift/blob/master/CONTRIBUTING.md
has more details and tips for committing properly.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
