kpumuk opened a new pull request, #3640:
URL: https://github.com/apache/thrift/pull/3640
<!-- Explain the changes in the pull request below: -->
Ruby’s `MemoryBufferTransport#read` did not reject negative lengths
consistently. With the native extension loaded, a negative length could
terminate the Ruby process. The pure-Ruby implementation instead raised an
unrelated exception after changing the transport’s read position.
This change rejects negative lengths with
`TransportException::NEGATIVE_SIZE` before touching the buffer. It also avoids
overflowing the native read index when an oversized read follows an earlier
read, while preserving the existing behavior for valid and out-of-range lengths.
<!-- We recommend you review the checklist/tips before submitting a pull
request. -->
- [x] Did you create an [Apache
Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket?
[THRIFT-6099](https://issues.apache.org/jira/browse/THRIFT-6099)
- [x] If a ticket exists: Does your pull request title follow the pattern
"THRIFT-NNNN: describe my issue"?
- [x] Did you squash your changes to a single commit? (not required, but
preferred)
- [x] Did you do your best to avoid breaking changes? If one was needed,
did you label the Jira ticket with "Breaking-Change"?
- [ ] If your change does not involve any code, include `[skip ci]` anywhere
in the commit message to free up build resources.
<!--
The Contributing Guide at:
https://github.com/apache/thrift/blob/master/CONTRIBUTING.md
has more details and tips for committing properly.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
